fix: ensure graceful shutdown and container stop when stopApp is called (#5494)

* fix: graceful shutdown handling for backend app

* chore: add startup delay to health check script

healthcheck.sh

@@ -8,6 +8,14 @@ curlCheck() {
   fi
 }
 
+# Wait for initial startup period to avoid unnecessary error logs
+# Check if the container has been running for at least 15 seconds
+UPTIME=$(awk '{print int($1)}' /proc/uptime)
+if [ "$UPTIME" -lt 15 ]; then
+  echo "Container still starting up (uptime: ${UPTIME}s), skipping health check..."
+  exit 0
+fi
+
 if [ "$ENABLE_SUBPATH_BASED_ACCESS" = "true" ]; then
   curlCheck "http://localhost:${HOPP_AIO_ALTERNATE_PORT:-80}/backend/ping" || exit 1
 else

packages/hoppscotch-backend/src/infra-config/helper.ts

@@ -370,14 +370,16 @@ export async function isInfraConfigTablePopulated(): Promise<boolean> {
 }
 
 /**
- * Stop the app after 5 seconds
- * (Docker will re-start the app)
+ * Stop the app after 5 seconds with graceful shutdown
+ * (Sends SIGTERM to trigger NestJS graceful shutdown, then Docker container stops)
  */
 export function stopApp() {
   console.log('Stopping app in 5 seconds...');
 
   setTimeout(() => {
-    console.log('Stopping app now...');
+    console.log('Stopping app now with graceful shutdown...');
+    // Send SIGTERM to the current process to trigger graceful shutdown
+    // This will call app.close() which triggers onModuleDestroy lifecycle hooks
     process.kill(process.pid, 'SIGTERM');
   }, 5000);
 }

packages/hoppscotch-backend/src/main.ts

@@ -99,8 +99,10 @@ async function bootstrap() {
 
   // Graceful shutdown
   process.on('SIGTERM', async () => {
-    console.info('SIGTERM signal received');
+    console.info('SIGTERM signal received, initiating graceful shutdown...');
     await app.close();
+    console.info('Application closed successfully');
+    process.exit(0);
   });
 }
 

prod.Dockerfile

@@ -183,7 +183,7 @@ COPY aio-subpath-access.Caddyfile /etc/caddy/aio-subpath-access.Caddyfile
 
 ENTRYPOINT [ "tini", "--" ]
 COPY --chmod=755 healthcheck.sh /
-HEALTHCHECK --interval=2s CMD /bin/sh /healthcheck.sh
+HEALTHCHECK --interval=2s --start-period=15s CMD /bin/sh /healthcheck.sh
 
 WORKDIR /dist/backend
 CMD ["node", "/usr/src/app/aio_run.mjs"]