thibaud-lclr/api-client
1
0
Fork 0
Code Packages Activity Actions

fix: email not being checked case insensitive on team invitation acceptance (#3174)

Browse source
This commit is contained in:
Andrew Bastin 2023-07-11 20:03:08 +05:30 committed by GitHub
parent b2af353941
commit b29c04c28d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts
View file

@ -256,7 +256,9 @@ export class TeamInvitationService {
pipe(
undefined,
TE.fromPredicate(
(a) => acceptedBy.email === invitation.inviteeEmail,
() =>
acceptedBy.email.toLowerCase() ===
invitation.inviteeEmail.toLowerCase(),
() => TEAM_INVITE_EMAIL_DO_NOT_MATCH,
),
),

4
packages/hoppscotch-backend/src/team-invitation/team-invitee.guard.ts
View file

@ -5,7 +5,6 @@ import * as O from 'fp-ts/Option';
import * as T from 'fp-ts/Task';
import * as TE from 'fp-ts/TaskEither';
import { GqlExecutionContext } from '@nestjs/graphql';
import { User } from 'src/user/user.model';
import {
BUG_AUTH_NO_USER_CTX,
BUG_TEAM_INVITE_NO_INVITE_ID,
@ -55,7 +54,8 @@ export class TeamInviteeGuard implements CanActivate {
// Check if the emails match
TE.chainW(
TE.fromPredicate(
({ user, invite }) => user.email === invite.inviteeEmail,
({ user, invite }) =>
user.email.toLowerCase() === invite.inviteeEmail.toLowerCase(),
() => TEAM_INVITE_EMAIL_DO_NOT_MATCH,
),
),