thibaud-lclr/api-client
1
0
Fork 0
Code Packages Activity Actions

fix: ensure correct parser for xml and plaintext (#5597)

Browse source 
Co-authored-by: James George <25279263+jamesgeorge007@users.noreply.github.com>
This commit is contained in:
jaeyonglee-int 2025-12-02 06:53:51 -05:00 committed by GitHub
parent 88c7e189cf
commit aed032391f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 20 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/hoppscotch-common/src/components.d.ts vendored
View file

@ -1,8 +1,11 @@
/* eslint-disable */
// @ts-nocheck
// biome-ignore lint: disable
// oxlint-disable
// ------
// Generated by unplugin-vue-components
// Read more: https://github.com/vuejs/core/pull/3399
// biome-ignore lint: disable
export {}
/* prettier-ignore */

6
packages/hoppscotch-common/src/components/http/RawBody.vue
View file

@ -35,6 +35,7 @@
'application/hal+json',
'application/vnd.api+json',
'application/xml',
'text/xml',
].includes(body.contentType)
"
v-tippy="{ theme: 'tooltip' }"
@ -209,7 +210,10 @@ const prettifyRequestBody = () => {
try {
if (body.value.contentType.endsWith("json")) {
prettifyBody = prettifyJSONC(rawParamsBody.value as string)
} else if (body.value.contentType === "application/xml") {
} else if (
body.value.contentType === "application/xml" ||
body.value.contentType === "text/xml"
) {
prettifyBody = prettifyXML(rawParamsBody.value as string)
}
rawParamsBody.value = prettifyBody

15
packages/hoppscotch-common/src/helpers/__tests__/editorutils.spec.js
View file

@ -10,22 +10,23 @@ describe("getEditorLangForMimeType", () => {
test("returns 'xml' for valid XML mimes", () => {
expect(getEditorLangForMimeType("application/xml")).toMatch("xml")
expect(getEditorLangForMimeType("text/xml")).toMatch("xml")
})
test("returns 'html' for valid HTML mimes", () => {
expect(getEditorLangForMimeType("text/html")).toMatch("html")
})
test("returns 'text/x-yaml' for plain text mime", () => {
expect(getEditorLangForMimeType("text/plain")).toMatch("text/x-yaml")
test("returns text/plain for plain text mime", () => {
expect(getEditorLangForMimeType("text/plain")).toBe("text/plain")
})
test("returns 'text/x-yaml' for unimplemented mimes", () => {
expect(getEditorLangForMimeType("image/gif")).toMatch("text/x-yaml")
test("returns text/plain for unimplemented mimes", () => {
expect(getEditorLangForMimeType("image/gif")).toBe("text/plain")
})
test("returns 'text/x-yaml' for null/undefined mimes", () => {
expect(getEditorLangForMimeType(null)).toMatch("text/x-yaml")
expect(getEditorLangForMimeType(undefined)).toMatch("text/x-yaml")
test("returns text/plain for null/undefined mimes", () => {
expect(getEditorLangForMimeType(null)).toBe("text/plain")
expect(getEditorLangForMimeType(undefined)).toBe("text/plain")
})
})

5
packages/hoppscotch-common/src/helpers/editorutils.ts
View file

@ -1,5 +1,6 @@
const mimeToMode = {
"text/plain": "text/x-yaml",
"text/plain": "text/plain",
"text/xml": "application/xml",
"text/html": "htmlmixed",
"application/xml": "application/xml",
"application/hal+json": "application/ld+json",
@ -8,5 +9,5 @@ const mimeToMode = {
}
export function getEditorLangForMimeType(mimeType: string): string {
return mimeToMode[mimeType] || "text/x-yaml"
return mimeToMode[mimeType] || "text/plain"
}