From 6729d7c7fd57ffc96e61b0f27dc0202f8db2fdcd Mon Sep 17 00:00:00 2001 From: jamesgeorge007 <25279263+jamesgeorge007@users.noreply.github.com> Date: Wed, 29 Oct 2025 23:09:01 +0530 Subject: [PATCH] refactor(common): remove redundant logs --- .../src/components/collections/ImportExport.vue | 16 ++-------------- .../collections/graphql/ImportExport.vue | 16 ++-------------- .../components/mockServer/CreateMockServer.vue | 4 +--- .../src/components/mockServer/EditMockServer.vue | 6 ++---- .../src/components/mockServer/LogSection.vue | 8 ++------ .../mockServer/MockServerDashboard.vue | 6 ++---- .../src/components/mockServer/MockServerLogs.vue | 6 ++---- .../src/helpers/backend/mutations/MockServer.ts | 1 - .../helpers/backend/mutations/UserCollection.ts | 7 ++----- 9 files changed, 15 insertions(+), 55 deletions(-) diff --git a/packages/hoppscotch-common/src/components/collections/ImportExport.vue b/packages/hoppscotch-common/src/components/collections/ImportExport.vue index 3eb58aad..d1ac2ace 100644 --- a/packages/hoppscotch-common/src/components/collections/ImportExport.vue +++ b/packages/hoppscotch-common/src/components/collections/ImportExport.vue @@ -141,29 +141,17 @@ const importToPersonalWorkspace = async (collections: HoppCollection[]) => { // Replace local collections with backend collections setRESTCollections(fetchResult.right) } else { - console.warn( - "Failed to fetch collections from backend after import:", - fetchResult.left - ) - // Still append to local store as fallback + // Failed to fetch, append to local store as fallback appendRESTCollections(collections) } return E.right({ success: true }) } // Backend import failed, fall back to local storage - console.warn( - "Backend import failed, falling back to local storage:", - res.left - ) appendRESTCollections(collections) return E.right({ success: true }) - } catch (error) { + } catch { // Backend import failed, fall back to local storage - console.warn( - "Backend import failed, falling back to local storage:", - error - ) appendRESTCollections(collections) return E.right({ success: true }) } diff --git a/packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue b/packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue index 11a598b7..b0e63b87 100644 --- a/packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue +++ b/packages/hoppscotch-common/src/components/collections/graphql/ImportExport.vue @@ -258,11 +258,7 @@ const handleImportToStore = async (gqlCollections: HoppCollection[]) => { // Replace local collections with backend collections setGraphqlCollections(fetchResult.right) } else { - console.warn( - "Failed to fetch collections from backend after import:", - fetchResult.left - ) - // Still append to local store as fallback + // Failed to fetch, append to local store as fallback appendGraphqlCollections(gqlCollections) } @@ -270,19 +266,11 @@ const handleImportToStore = async (gqlCollections: HoppCollection[]) => { return } // Backend import failed, fall back to local storage - console.warn( - "Backend import failed, falling back to local storage:", - res.left - ) appendGraphqlCollections(gqlCollections) toast.success(t("state.file_imported")) return - } catch (error) { + } catch { // Backend import failed, fall back to local storage - console.warn( - "Backend import failed, falling back to local storage:", - error - ) appendGraphqlCollections(gqlCollections) toast.success(t("state.file_imported")) return diff --git a/packages/hoppscotch-common/src/components/mockServer/CreateMockServer.vue b/packages/hoppscotch-common/src/components/mockServer/CreateMockServer.vue index 2cf5310e..fbd00e89 100644 --- a/packages/hoppscotch-common/src/components/mockServer/CreateMockServer.vue +++ b/packages/hoppscotch-common/src/components/mockServer/CreateMockServer.vue @@ -476,7 +476,6 @@ const createMockServer = async () => { TE.match( (error) => { // `error` here is the message string produced by the mutation helper. - console.error("Failed to create mock server:", error) // Show the backend-provided error message if available, otherwise fallback to generic toast.error(String(error) || t("error.something_went_wrong")) loading.value = false @@ -508,8 +507,7 @@ const toggleMockServer = async () => { await pipe( updateMockServer(existingMockServer.value.id, { isActive: newActiveState }), TE.match( - (error) => { - console.error("Failed to update mock server:", error) + () => { toast.error(t("error.something_went_wrong")) loading.value = false }, diff --git a/packages/hoppscotch-common/src/components/mockServer/EditMockServer.vue b/packages/hoppscotch-common/src/components/mockServer/EditMockServer.vue index 36b787b1..e4ca643e 100644 --- a/packages/hoppscotch-common/src/components/mockServer/EditMockServer.vue +++ b/packages/hoppscotch-common/src/components/mockServer/EditMockServer.vue @@ -221,8 +221,7 @@ const updateMockServer = async () => { await pipe( updateMockServerMutation(props.mockServer.id, payload), TE.match( - (error) => { - console.error("Failed to update mock server:", error) + () => { toast.error(t("error.something_went_wrong")) loading.value = false }, @@ -253,8 +252,7 @@ const toggleMockServer = async () => { await pipe( updateMockServerMutation(props.mockServer.id, { isActive: newActiveState }), TE.match( - (error) => { - console.error("Failed to update mock server:", error) + () => { toast.error(t("error.something_went_wrong")) loading.value = false }, diff --git a/packages/hoppscotch-common/src/components/mockServer/LogSection.vue b/packages/hoppscotch-common/src/components/mockServer/LogSection.vue index f2c35e3a..29f44658 100644 --- a/packages/hoppscotch-common/src/components/mockServer/LogSection.vue +++ b/packages/hoppscotch-common/src/components/mockServer/LogSection.vue @@ -104,11 +104,7 @@ const formattedContent = computed(() => { const copyContent = () => { if (!props.content) return - try { - copyToClipboard(formattedContent.value) - copySuccess.value = true - } catch (error) { - console.error("Failed to copy content:", error) - } + copyToClipboard(formattedContent.value) + copySuccess.value = true } diff --git a/packages/hoppscotch-common/src/components/mockServer/MockServerDashboard.vue b/packages/hoppscotch-common/src/components/mockServer/MockServerDashboard.vue index 2509900b..4f379eb1 100644 --- a/packages/hoppscotch-common/src/components/mockServer/MockServerDashboard.vue +++ b/packages/hoppscotch-common/src/components/mockServer/MockServerDashboard.vue @@ -282,8 +282,7 @@ const toggleMockServer = async (mockServer: MockServer) => { await pipe( updateMockServerMutation(mockServer.id, { isActive: newActiveState }), TE.match( - (error) => { - console.error("Failed to update mock server:", error) + () => { toast.error(t("error.something_went_wrong")) loading.value = false }, @@ -325,8 +324,7 @@ const confirmDelete = async () => { await pipe( deleteMockServerMutation(mockServer.id), TE.match( - (error) => { - console.error("Failed to delete mock server:", error) + () => { toast.error(t("error.something_went_wrong")) loading.value = false pendingMockServerToDelete.value = null diff --git a/packages/hoppscotch-common/src/components/mockServer/MockServerLogs.vue b/packages/hoppscotch-common/src/components/mockServer/MockServerLogs.vue index e3862dea..720b2599 100644 --- a/packages/hoppscotch-common/src/components/mockServer/MockServerLogs.vue +++ b/packages/hoppscotch-common/src/components/mockServer/MockServerLogs.vue @@ -143,8 +143,7 @@ const fetchLogs = async () => { await pipe( getMockServerLogs(props.mockServerID), TE.match( - (err) => { - console.error("Failed to load logs", err) + () => { toast.error(t("error.something_went_wrong")) loading.value = false }, @@ -172,8 +171,7 @@ const confirmDelete = async () => { await pipe( deleteMockServerLog(logToDelete.value), TE.match( - (err) => { - console.error("Failed to delete log", err) + () => { toast.error(t("error.something_went_wrong")) }, (res) => { diff --git a/packages/hoppscotch-common/src/helpers/backend/mutations/MockServer.ts b/packages/hoppscotch-common/src/helpers/backend/mutations/MockServer.ts index 71d3ca70..22656cb5 100644 --- a/packages/hoppscotch-common/src/helpers/backend/mutations/MockServer.ts +++ b/packages/hoppscotch-common/src/helpers/backend/mutations/MockServer.ts @@ -224,7 +224,6 @@ export const getErrorMessage = (err: GQLError | string | Error) => { if (!gErr) return t("error.something_went_wrong") if (gErr.type === "network_error") { - console.error(gErr.error) return t("error.network_error") } diff --git a/packages/hoppscotch-common/src/helpers/backend/mutations/UserCollection.ts b/packages/hoppscotch-common/src/helpers/backend/mutations/UserCollection.ts index 3329ccc2..24c3ca82 100644 --- a/packages/hoppscotch-common/src/helpers/backend/mutations/UserCollection.ts +++ b/packages/hoppscotch-common/src/helpers/backend/mutations/UserCollection.ts @@ -77,9 +77,7 @@ function convertUserRequestToHoppRequest( } return request - } catch (error) { - console.warn("Failed to parse user request data:", error) - + } catch { // Return a default request if parsing fails if (userRequest.type === ReqType.Rest) { const defaultRequest = getDefaultRESTRequest() @@ -115,8 +113,7 @@ function parseUserCollectionData(data: string | null | undefined) { headers: parsedData?.headers || defaultDataProps.headers, variables: parsedData?.variables || defaultDataProps.variables, } - } catch (error) { - console.warn("Failed to parse user collection data:", error) + } catch { return defaultDataProps } }