From 65046526f04f504717acea93001e3972dab3971a Mon Sep 17 00:00:00 2001 From: Leonic <88329746+Leon-Luu@users.noreply.github.com> Date: Fri, 23 Jan 2026 10:05:02 +0100 Subject: [PATCH] fix(common): ignore shift keybindings in CodeMirror editors (#5794) --- packages/hoppscotch-common/src/helpers/keybindings.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/hoppscotch-common/src/helpers/keybindings.ts b/packages/hoppscotch-common/src/helpers/keybindings.ts index 636b0f65..af49df6c 100644 --- a/packages/hoppscotch-common/src/helpers/keybindings.ts +++ b/packages/hoppscotch-common/src/helpers/keybindings.ts @@ -262,11 +262,11 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null { // All key combos backed by modifiers are valid shortcuts (whether currently typing or not) if (modifierKey) { - // If the modifier is shift and the target is an input, we ignore + // If the modifier is shift and the target is an input or codemirror editor, we ignore if ( modifierKey === "shift" && isDOMElement(target) && - isTypableElement(target) + (isTypableElement(target) || isCodeMirrorEditor(target)) ) { return null }