fix: sync all settings actions in SH (#4263)

This commit is contained in:
James George 2024-08-19 12:52:10 -07:00 committed by GitHub
parent 775051bac3
commit 559c71e39b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 22 additions and 4 deletions

View file

@ -80,7 +80,7 @@ export const getSyncInitFunction = <T extends DispatchingStore<any, any>>(
)
}
stopSubscriptions = startSubscriptions()
stopSubscriptions = startSubscriptions?.()
}
function stopListeningToSubscriptions() {
@ -90,7 +90,7 @@ export const getSyncInitFunction = <T extends DispatchingStore<any, any>>(
)
}
stopSubscriptions()
stopSubscriptions?.()
}
return {

View file

@ -9,9 +9,18 @@ import { updateUserSettings } from "./settings.api"
export const settingsSyncDefinition: StoreSyncDefinitionOf<
typeof settingsStore
> = {
toggleSetting() {
updateUserSettings(JSON.stringify(settingsStore.value))
},
toggleNestedSetting() {
updateUserSettings(JSON.stringify(settingsStore.value))
},
applySetting() {
updateUserSettings(JSON.stringify(settingsStore.value))
},
applyNestedSetting() {
updateUserSettings(JSON.stringify(settingsStore.value))
},
}
export const settingsSyncer = getSyncInitFunction(

View file

@ -80,7 +80,7 @@ export const getSyncInitFunction = <T extends DispatchingStore<any, any>>(
)
}
stopSubscriptions = startSubscriptions()
stopSubscriptions = startSubscriptions?.()
}
function stopListeningToSubscriptions() {
@ -90,7 +90,7 @@ export const getSyncInitFunction = <T extends DispatchingStore<any, any>>(
)
}
stopSubscriptions()
stopSubscriptions?.()
}
return {

View file

@ -9,9 +9,18 @@ import { updateUserSettings } from "./settings.api"
export const settingsSyncDefinition: StoreSyncDefinitionOf<
typeof settingsStore
> = {
toggleSetting() {
updateUserSettings(JSON.stringify(settingsStore.value))
},
toggleNestedSetting() {
updateUserSettings(JSON.stringify(settingsStore.value))
},
applySetting() {
updateUserSettings(JSON.stringify(settingsStore.value))
},
applyNestedSetting() {
updateUserSettings(JSON.stringify(settingsStore.value))
},
}
export const settingsSyncer = getSyncInitFunction(