thibaud-lclr/api-client
1
0
Fork 0
Code Packages Activity Actions

feat(desktop): update check timeout (#4868)

Browse source 
`2s` -> `5s`
This commit is contained in:
Shreyas 2025-03-10 22:41:57 +05:30 committed by GitHub
parent 072c759cd0
commit 3f37a055b1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/hoppscotch-desktop/src/utils/updater.ts
View file

@ -12,19 +12,24 @@ export class UpdaterService {
});
}
async checkForUpdates(timeout = 2000): Promise<CheckResult> {
async checkForUpdates(timeout = 5000): Promise<CheckResult> {
try {
await this.saveUpdateState({
status: UpdateStatus.CHECKING
});
// Create a timeout promise, this is just to make sure we don't keep checking for updates indefinitely
// NOTE: Also `checkUpdate` tends to hang indefinitely in dev mode, but works in build
// This creats a timeout promise that is slightly longer than `check`'s internal timeout,
// this is just to make sure we don't keep checking for updates indefinitely.
// NOTE: `check` tends to hang indefinitely in dev mode, but works in build,
// so this is just in case this ever happens on prod.
const timeoutPromise = new Promise<null>((resolve) => {
// Longer local timeout to make sure it only triggers
// if there's an issue with `check`'s built-in timeout.
const bufferTimeout = timeout + 1000;
setTimeout(() => {
console.log("Update check timeout reached, proceeding with app load");
console.log("Update check exceeded buffer timeout, likely hanging in check function");
resolve(null);
}, timeout);
}, bufferTimeout);
});
const updateResult = await Promise.race([