thibaud-lclr/api-client
1
0
Fork 0
Code Packages Activity Actions

route navigation no longer happening in typable areas (#1862)

Browse source
This commit is contained in:
Rishabh kalra 2021-10-09 06:45:17 +05:30 committed by GitHub
parent 47b341d50e
commit 0394deaeef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/hoppscotch-app/helpers/keybindings.ts
View file

@ -95,9 +95,8 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null {
const modifierKey = getActiveModifier(ev)
const target = ev.target
if (!modifierKey && !(isDOMElement(target) && isTypableElement(target))) {
// Check if we are having singulars instead
// override default behaviour if element is typable
if (modifierKey && isDOMElement(target) && isTypableElement(target)) {
const key = getPressedKey(ev)
if (!key) return null
@ -112,7 +111,6 @@ function generateKeybindingString(ev: KeyboardEvent): ShortcutKey | null {
function getPressedKey(ev: KeyboardEvent): Key | null {
const val = ev.key.toLowerCase()
// Check arrow keys
if (val === "arrowup") return "up"
else if (val === "arrowdown") return "down"